@daviddias Please give some feedback on this.

@Alexander255 reviewing 2700 LOC changed in a codebase that I never looked much is hard. Could you list out what this PR does? Which funcs it implements? Which ones it doesn't implements? Which ones have tests? What's next? And so ?

@daviddias: Fair enough I guess 🙂

The main point of this PR is changing the way the existing IPFS API is presented to users of the library. For instance, previously ipfs files cp would have been client.files_cp(…) in Python; with this PR it would become client.files.cp(…) (like in JavaScript). I made these changes in accordance with the ipfs-interface-core spec. In particular:

• I split the giant client.py file into several roughly along the lines of that spec (but this is not user-visible anyways)
  • See ipfsapi/client/__init__.py for the merging
• I changed method names to be of the client.a.b(…) style where appropriate
  • For instance ipfsapi/client/files.py

(Not that this will also be released as part of the new ipfshttpclient library with the current code being for the old ipfsapi library and including the backward-compatibility shims.)

Some questions, mainly based on the discussions in https://github.com/ipfs/interface-ipfs-core/issues/284:

• Is the split of the files module into client.{add,file_ls,get,cat,ls} on the one hand vs client.files.{cp,ls,mkdir,mv,read,rm,stat,write} on the hand still current or should things be done differently now that we have a chance to break API? (Remember I'll push an update for the old library adding shims and wrapping the new version.)
• What's the point of /api/v0/file/ls vs /api/v0/ls anyways? Can one of these be dropped? Found Deprecate ipfs file ls ipfs/kubo#5806: Yes, ipfs file ls is scheduled for removal soon.
• What's this chat about ipfsx and how does it relate to the exposed interfaces?
• Is /api/v0/bitswap/unwant dead? It's giving me errors on newer versions of IPFS. Found remove bitswap unwant ipfs/kubo#5308: The short answer is “yes”.
• Any other feedback you may have.

Hope this is more useful this time 😊

@daviddias: Ping

@daviddias: Ping again. I see that js-ipfs recently switched to the new namespace for the {add,get,cat,ls}. This is not reflected in https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/FILES.md however, at the moment.

Those changes are part of a bigger revamp of the whole API around files at IPFS. More discussions at:

• https://github.com/ipfs/interface-ipfs-core/issues/284
• https://github.com/ipfs/interface-ipfs-core/issues/412
• Awesome Endeavour: Async Iterators ipfs/js-ipfs#1670

Lot's of context there ^^

Is the split of the files module into client.{add,file_ls,get,cat,ls} on the one hand vs client.files.{cp,ls,mkdir,mv,read,rm,stat,write} on the hand still current or should things be done differently now that we have a chance to break API? (Remember I'll push an update for the old library adding shims and wrapping the new version.)

The split is due that in go-ipfs, any command that is below ipfs.files is actually acting on top of the MFS subsystem, while any command related to files on ipfs. is just default baseline commands. There is a proposal to merge both.

What's this chat about ipfsx and how does it relate to the exposed interfaces?

It is our experimental platform o make the APIs more ergonomic for JavaScript developers.

@daviddias: Ping again. I see that js-ipfs recently switched to the new namespace for the {add,get,cat,ls}. This is not reflected in https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/FILES.md however, at the moment.

This will be reflected soon on interface-ipfs-core too. I recommend following that for the py-ipfs-api. //cc @alanshaw

@daviddias: Thanks for your response!

It looks like I misread the release announcement at ipfs/js-ipfs#1721: JS-IPFS moved the non-MFS file APIs from the files.*-namespace to top-level, not the other way round! Meaning that the code now behaves like it was outlined in https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/FILES.md all along, no? (I don't care about the JS-specific details regarding pull-streams et al here since that is JS-stuff not Python-stuff.)

Thank you, I'll do it this way then and wait for further developments down the line, when/if the file.*-namespace and top-level are merged.